General QoL Improvements - Docker related #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 27, 2024 11:19
Being a drop-in replacement, this should not require any additional rework.
…aring for more adequate container-registry based pull.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hyperglass can now be used directly from GHCR, without needing to clone the full git repository.
Build caching has been improved, so that it is not needed to fully download all the dependencies at each change, but only when the dependencies change.
Redis has been replaced with valkey, due to license changes.
Motivation and Context
Cloning a full repo and having to deal with configuration files is against the purpose of Docker simplicity, in my view.
This allows to just have a
compose.yamlfile and be ready to go, without having to deal with other things. This also allows easier integration in systems where you can only deploy containers from Registries.Tests
Verified with GitHub CI + MacOS (Apple Silicon) - Everything works as expected.
Requires #297 to be merged.